Tanstack Start - Remove splat from sign-in page file route path#2346
Tanstack Start - Remove splat from sign-in page file route path#2346lawandothman wants to merge 1 commit intoclerk:mainfrom
Conversation
|
@lawandothman is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @lawandothman Thank you for reporting this! I've tested out the guide and I'm not able to re-produce the issue. I created this branch https://github.com/clerk/clerk-tanstack-react-start-quickstart/tree/sign-in-or-up following the current guide and it all seems to work as I would expect. Would you be willing to create a repo with the issue happening? |
|
Hey @NWylynko, The example you linked doesn't have any server side authentication. If you follow the guide for the server side auth here https://clerk.com/docs/quickstarts/tanstack-react-start#server-side you will see the redirect to P.S. the docs have been updated in that page to use // This will error because you're redirecting to a path that doesn't exist yet
// You can create a sign-in route to handle this
// See https://clerk.com/docs/references/tanstack-start/custom-sign-in-or-up-page
throw redirect({
to: '/sign-in',
}) |
|
Hey @lawandothman , thanks for reporting the issue and providing a PR! I'm actually not sure if this was the behavior pre-devinxi, but I sent a message to one of the tanstaack maintainers and asked about the |
|
hey @wobsoriano, perfect thank you! :) I can confirm that this wasn't a thing pre-devinxi. Seems to be introduced here where the route explicitly falls back to |
appreciate the detective skills here! |
|
@NWylynko you are the best! |
|
Fixed in TanStack/router#4558 thanks again @lawandothman |


🔎 Previews:
What does this solve?
/sign-in/$to/sign-in$a path param and defaults to undefined. So if the user is logged out and visit/the redirect sends them to/sign-in/undefinedWhat changed?
sign-in.tsxinstead ofsign-in.$.tsxChecklist